Update check_board_header.py to check for missing ifndefs#2927
Open
Update check_board_header.py to check for missing ifndefs#2927
Conversation
Any board #defines with a pico_board_cmake_set_default counterpart, or that start with PICO_DEFAULT_, should be wrapped in an #ifndef guard so that they're easy to override Also fixes a few board-header errors that this detected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any board
#defines with apico_board_cmake_set_defaultcounterpart, or that start withPICO_DEFAULT_, should be wrapped in an#ifndefguard so that they're easy to override.Also fixes a few board-header errors that this detected.
(as discussed with @will-v-pi in #2919 )